Skip to content

Remove refs from Pat slices #87140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 16, 2021
Merged

Remove refs from Pat slices #87140

merged 1 commit into from
Jul 16, 2021

Conversation

camsteffen
Copy link
Contributor

@camsteffen camsteffen commented Jul 14, 2021 •
edited
Loading

Changes PatKind::Or(&'hir [&'hir Pat<'hir>]) to PatKind::Or(&'hir [Pat<'hir>]) and others. This is more consistent with ExprKind, saves a little memory, and is a little easier to use.

@rust-highfive
Copy link
Contributor

Some changes occurred in src/tools/clippy.

cc @rust-lang/clippy

@rust-highfive
Copy link
Contributor

r? @nagisa

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 14, 2021
@camsteffen
Copy link
Contributor Author

@rust-timer queue

@rust-timer
Copy link
Collaborator

Insufficient permissions to issue commands to rust-timer.

@jyn514
Copy link
Member

jyn514 commented Jul 14, 2021

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jul 14, 2021
@bors
Copy link
Collaborator

bors commented Jul 14, 2021

⌛ Trying commit 4b10218 with merge cd6663f81419d3f4ed7b8dccfa7ddf90c489ce90...

@bors
Copy link
Collaborator

bors commented Jul 14, 2021

☀️ Try build successful - checks-actions
Build commit: cd6663f81419d3f4ed7b8dccfa7ddf90c489ce90 (cd6663f81419d3f4ed7b8dccfa7ddf90c489ce90)

@rust-timer
Copy link
Collaborator

Queued cd6663f81419d3f4ed7b8dccfa7ddf90c489ce90 with parent e87188c, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking try commit (cd6663f81419d3f4ed7b8dccfa7ddf90c489ce90): comparison url.

Summary: This benchmark run did not return any significant changes.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf -perf-regression

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jul 15, 2021
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@camsteffen
Copy link
Contributor Author

Tried to remove another ref but it looks like I can't so reverted.

oli-obk
oli-obk reviewed Jul 15, 2021
View reviewed changes
@oli-obk
Copy link
Contributor

oli-obk commented Jul 15, 2021

@bors r+

@bors
Copy link
Collaborator

bors commented Jul 15, 2021

📌 Commit 4b10218 has been approved by oli-obk

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 15, 2021
@oli-obk
Copy link
Contributor

oli-obk commented Jul 15, 2021

@bors rollup-

GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Jul 15, 2021
@GuillaumeGomez
Rollup merge of rust-lang#87140 - camsteffen:pat-slice-refs, r=oli-obk
afbb612 
Remove refs from Pat slices

Changes `PatKind::Or(&'hir [&'hir Pat<'hir>])` to `PatKind::Or(&'hir [Pat<'hir>])` and others. This is more consistent with `ExprKind`, saves a little memory, and is a little easier to use.
@GuillaumeGomez GuillaumeGomez mentioned this pull request Jul 15, 2021
Closed
@GuillaumeGomez
Copy link
Member

There is a conflict to be resolved.

@bors: r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 15, 2021
@bors
Copy link
Collaborator

bors commented Jul 15, 2021

☔ The latest upstream changes (presumably #87152) made this pull request unmergeable. Please resolve the merge conflicts.

@oli-obk
Copy link
Contributor

oli-obk commented Jul 16, 2021

@bors r+

@bors
Copy link
Collaborator

bors commented Jul 16, 2021

📌 Commit 1537cd4 has been approved by oli-obk

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 16, 2021
@bors
Copy link
Collaborator

bors commented Jul 16, 2021

⌛ Testing commit 1537cd4 with merge 2119976...

@bors
Copy link
Collaborator

bors commented Jul 16, 2021

☀️ Test successful - checks-actions
Approved by: oli-obk
Pushing 2119976 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jul 16, 2021
@bors bors merged commit 2119976 into rust-lang:master Jul 16, 2021
@rustbot rustbot added this to the 1.55.0 milestone Jul 16, 2021
flip1995 pushed a commit to flip1995/rust that referenced this pull request Jul 19, 2021
@bors
Auto merge of rust-lang#87140 - camsteffen:pat-slice-refs, r=oli-obk
1b0e578 
Remove refs from Pat slices

Changes `PatKind::Or(&'hir [&'hir Pat<'hir>])` to `PatKind::Or(&'hir [Pat<'hir>])` and others. This is more consistent with `ExprKind`, saves a little memory, and is a little easier to use.
@matthiaskrgr matthiaskrgr mentioned this pull request Sep 20, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oli-obk oli-obk oli-obk left review comments

Assignees

@nagisa nagisa

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.55.0
Development

Successfully merging this pull request may close these issues.
10 participants
@camsteffen @rust-highfive @rust-timer @jyn514 @bors @rust-log-analyzer @oli-obk @GuillaumeGomez @nagisa @rustbot